letters icon indicating copy to clipboard operation
letters copied to clipboard

CI does not run tests

Open aronerben opened this issue 3 years ago • 2 comments

The current GitHub workflow runs make test which does not exist, only make test-all. Either create a target for only unit tests or change the CI to use the test-all target.

aronerben avatar Aug 13 '22 11:08 aronerben

I think the right thing to do here is to change the makefile target to test and run non-service tests. Service tests relies on external services when sending emails and the validation is expected to happen manually, so it does not make sense to run them by the CI.

mikonieminen avatar Aug 15 '22 19:08 mikonieminen

I agree with Miko

joseferben avatar Aug 16 '22 06:08 joseferben