Encryption Admin Settings are shown even when encryption app is disabled

[cortho]

ownCloud 10.2.1.4 fresh install

Even when the encryption app is disabled, admin settings for encryption are shown and worse: it is possible to enable server-side encryption while the app remains disabled.

So it is possible for an admin to "pseudo enable" server-side-encryption (which cannot be undone), which leads to big inconsistency.

I have the strong feeling that the closed issue https://github.com/owncloud/core/issues/30447 is about the same story:

Steps to reproduce:

• With disabled encryption app visit Admin Settings -> Encryption
• Click Enable server-side-encryption and confirm with "Enable encryption"
• Try to create a public link share
• The message "No default encryption module defined" is shown and the public link cannot be created

The admin encryption settings must not be shown and must not have any effect when encryption app is disabled.

[phil-davis]

Even in current master (the coming 10.3) this is happening. And the encryption app has been put in a separate repo for 10.3

I see that in the core repo there is still stuff like:

settings/js/admin.js with references to enableEncryption and encryptionAPI settings/templates/panels/admin/encryption.php with the "Enable server-side encryption" checkbox.

@cortho thanks for noticing!

@PVince81 @micbar looks like there is more encryption cleanup to be done, which might fix this issue.

[PVince81]

let's not add more things for 10.3.0 as it's already overloaded, especially if this is not a regression

[phil-davis]

We have separated the encryption app from core - should we try to move "left behind" encryption references out to the encryption app? Or it's not so important because encryption is bundled in the release anyway?