android icon indicating copy to clipboard operation
android copied to clipboard

[FEATURE REQUEST] Align file icons and colors

Open tbsbdr opened this issue 1 year ago • 7 comments

Problem Icons and Icon colors are quite different between web and mobile clients. This is particularly noticeable when I e.g. do presentations, see screenshot.

screenshot_003187

Proposed solution

Align icon style and colors between web and mobile clients.

android

@JuancaG05 @jesmrec Whats you opinion - do you consider the proposal an improvement?

TASKS

  • [ ] Research (if needed)
  • [ ] Create branch feature/align_icons_and_colors
  • [ ] Development tasks
    • [ ] ...
    • [ ] Implement unit tests (if needed)
  • [ ] Code review and apply changes requested
  • [ ] Design test plan
  • [ ] QA
  • [ ] Merge branch feature/align_icons_and_colors

tbsbdr avatar Oct 01 '24 17:10 tbsbdr

yes, that's an improvement. We just need those icons from somewhere.

jesmrec avatar Oct 02 '24 06:10 jesmrec

Hey @tbsbdr! Yes, I agree with that. But, as @jesmrec states, we need to take those icons from somewhere, since the ones we have now come from long time ago. Would be cool to have some kind of "common database" to share the same icons (we don't receive them from server, they are saved locally in the app data), also if there is any new type of file added in the future 👍

JuancaG05 avatar Oct 02 '24 06:10 JuancaG05

We could proceed like that:

  1. replace current icons with the proposed one (same as web)
  2. discuss centralised icon set (not sure if this approach will be a benefit, as clients will always need some set of local icons - tbd)

The proposed icons are taken from web, resource-type-*.svg

mabye @kulmann and team can provide more structured guidance 🙏

tbsbdr avatar Oct 02 '24 17:10 tbsbdr

Issue gets solved? @tbsbdr

Kishubhai avatar Dec 29 '24 15:12 Kishubhai

I can not tell, @DeepDiver1975 might know or might know who can decide. (Im no longer in charge)

tbsbdr avatar Dec 31 '24 09:12 tbsbdr

This issue has been assigned to the team and it's in progress! 🚀 @Kishubhai if you want to contribute, take a look to issues with Contributions are welcome label. Feel free to comment if you have some questions about those issues 😄

joragua avatar Jan 10 '25 13:01 joragua

Seems the provided SVG are not valid since they are rectangular, and we (and in general, mobile apps) need squared images for these icons. The vectors could be modified before introducing them into the app, making them squared, but that's not the aim here, we should keep the same resources used in other clients. This won't be implemented FTM.

JuancaG05 avatar Jan 22 '25 07:01 JuancaG05