android icon indicating copy to clipboard operation
android copied to clipboard

[FEATURE REQUEST] Adding action buttons to the detail view of each file

Open fesave opened this issue 3 years ago • 2 comments

The purpose of this feature is to add three new buttons to the detail view and remove them from the toolbar menu.

We can follow the following design to perform this task:

Scribble:

known patterns / examples from other apps:

image

TASKS

  • [ ] Research (if needed)
  • [ ] Create branch feature/feature_name
  • [ ] Development tasks
    • [ ] Implement whatever
    • [ ] ...
  • [ ] Code review and apply changes requested
  • [ ] Design test plan
  • [ ] QA
  • [ ] Merge branch feature/feature_name into master

PR

  • App
  • Library (if needed)

fesave avatar Apr 27 '22 11:04 fesave

If the file is already downloaded, the Download option should be replace for Open

Also, i'd rename Share for Open with to avoid confusions with the Sharing feature

jesmrec avatar Apr 27 '22 12:04 jesmrec

Some issues to comment after checking the implementation at a glance (not QA). This is how it looks like:

File not downloaded File Downloaded
Screenshot 2022-05-27 at 14 13 45 Screenshot 2022-05-27 at 14 12 39

My considerations:

  • Open with icon is the same as the sharing one. i'd not use that one
  • When the file is downloaded, both options Open and Open with do the same. If the file is downloaded, i'd show only Open with and Send (at least, for the moment)
  • If the file is not downloaded, the Open with button does nothing.
  • I'd remove the separator. It does not look like good when the progress bar is displayed

jesmrec avatar May 27 '22 12:05 jesmrec