android icon indicating copy to clipboard operation
android copied to clipboard

Add test coverage to the project.

Open huxaiphaer opened this issue 6 years ago • 6 comments

PR Status : (Work in progress) What does this PR do ?

  • Adding test coverage to the project, to ensure that we track the tested edge cases. Tool/ Library used
  • Jacoco

huxaiphaer avatar Aug 05 '19 19:08 huxaiphaer

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


huxaiphaer seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Aug 05 '19 19:08 CLAassistant

Thanks for your contribution. We will check it and let you know our feedback.

If you plan to contribute to the app, i encourgae you to read our contributing file: https://github.com/owncloud/android/blob/master/CONTRIBUTING.md

and also i remember you must sign the CLA: https://cla-assistant.io/owncloud/android?pullRequest=2619

welcome!

jesmrec avatar Aug 06 '19 10:08 jesmrec

Hello @jesmrec , thanks for the feedback, but regarding CLA, I registered several times but there wasn't a reflecting on my PR. I don't know if this is a bug. Then secondly, is there a way developers can login with a testing server link, I didn't see it mentioned in the SETUP.md

huxaiphaer avatar Aug 06 '19 11:08 huxaiphaer

demo.owncloud.com is a testing server, with credentials demo/demo.

About CLA, any idea about @michaelstingl ?

jesmrec avatar Aug 06 '19 13:08 jesmrec

huxaiphaer seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it.

Please follow the instructions as posted by the CLA bot - THX

DeepDiver1975 avatar Aug 07 '19 07:08 DeepDiver1975

Some considerations

  • build.gradle is actually conflicting in the current PR, could you take a look?

  • I checked your code, and noticed that the tool is triggered by Travis. We are going to drop Travis as CI to use BitRise instead, which does not need yml file. So, we need to get a different way to trigger, if feasible

  • By triggering gradlew locally (same job tu set up in Travis if [ -e ./gradlew ]; then ./gradlew jacocoTestReport;else gradle jacocoTestReport;fi, no reports were generated in my machine neither in build/reports/ folder not in other one. Do i miss something? i would like to check in the project to evaluate how deep and interesting are the reports for us.

when these ones are fixed, we can keep checking if the tool fits our necessities. If you need something in which we can help you, let us know @huxaiphaer. Thanks a lot again!

jesmrec avatar Aug 27 '19 15:08 jesmrec