activity icon indicating copy to clipboard operation
activity copied to clipboard

Expired federated share has wrong activity message on sharee activity

Open grgprarup opened this issue 3 years ago • 0 comments

Steps to reproduce

  1. Create user Alice on the LOCAL server, and user Brian on the REMOTE server
  2. Share a file lorem.txt from user Alice to federated user Brian
  3. Accept incoming shares for federated user Brian
  4. Let it expire

Expected behaviour

It should be like, The share for 'lorem\.txt' has expired

Actual behaviour

It says, 'Alice' unshared 'lorem.txt' from you, Is this the expected behavior?

curl -k -XGET -uBrian:123456 http://localhost/fed-core/index.php/apps/activity/api/v2/activity
{
  "ocs": {
    "meta": {
      "status": "ok",
      "statuscode": 100,
      "message": null
    },
    "data": [
      {
        "activity_id": 134,
        "type": "remote_share",
        "user": null,
        "affecteduser": "Brian",
        "app": "files_sharing",
        "subject": "remote_share_unshared",
        "subjectparams": [
          {
            "value": "Alice@http://localhost/core",
            "type": "federated_cloud_id"
          },
          {
            "value": "lorem.txt",
            "type": "base"
          }
        ],
        "message": "",
        "messageparams": [],
        "link": "",
        "object_type": "files",
        "object_id": 0,
        "object_name": "",
        "subject_prepared": "<federated-cloud-id display-name=\"Alice@…\" user=\"Alice\" server=\"http://localhost/core\">Alice@http://localhost/core</federated-cloud-id> unshared <parameter>lorem.txt</parameter> from you",
        "message_prepared": "",
        "typeicon": "icon-shared",
        "datetime": "2022-06-29T07:16:16+00:00"
      },
      {
        "activity_id": 133,
        "type": "remote_share",
        "user": null,
        "affecteduser": "Brian",
        "app": "files_sharing",
        "subject": "remote_share_received",
        "subjectparams": [
          {
            "value": "Alice@http://localhost/core",
            "type": "federated_cloud_id"
          },
          {
            "value": "lorem.txt",
            "type": "base"
          },
          {
            "value": {
              "shareId": "38"
            },
            "type": "base"
          }
        ],
        "message": "",
        "messageparams": [],
        "link": "",
        "object_type": "files",
        "object_id": 2210,
        "object_name": "",
        "subject_prepared": "You received a new federated share <parameter>lorem.txt</parameter> from <federated-cloud-id display-name=\"Alice@…\" user=\"Alice\" server=\"http://localhost/core\">Alice@http://localhost/core</federated-cloud-id>",
        "message_prepared": "",
        "typeicon": "icon-shared",
        "datetime": "2022-06-28T07:14:30+00:00"
      },
    ]
  }
}

Server configuration

Where did you install ownCloud from: Latest github master

grgprarup avatar Jun 27 '22 07:06 grgprarup