manager icon indicating copy to clipboard operation
manager copied to clipboard

fix: logs data platform archive url payload

Open pfrayer opened this issue 1 year ago • 3 comments

Question Answer
Branch? master
Bug fix? yes
New feature? no
Breaking change? no
Ticket OB-5345
License BSD 3-Clause

  • [x] Try to keep pull requests small so they can be easily reviewed.
  • [x] Commits are signed-off
  • [x] Only FR translations have been updated
  • [x] Branch is up-to-date with target branch
  • [x] Lint has passed locally
  • [x] Standalone app was ran and tested locally
  • [x] Ticket reference is mentioned in linked commits (internal only)
  • [x] Breaking change is mentioned in relevant commits

Description

In Logs Data Platform, when downloading an archive, this API is called:

https://eu.api.ovh.com/console/#/dbaas/logs/%7BserviceName%7D/output/graylog/stream/%7BstreamId%7D/archive/%7BarchiveId%7D/url~POST

In the current code, a payload is given while no payload is expected. This PR removes the payload

pfrayer avatar Feb 28 '24 14:02 pfrayer

@pfrayer there is a typo in the commit title dlatform -> platform. Can you please correct it?

Nice catch, fixed

pfrayer avatar Feb 29 '24 07:02 pfrayer

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Mar 01 '24 10:03 sonarqubecloud[bot]

@anooparveti done

About signature, don't having the "Signed-off by:" doesn't mean the commit isn't signed:

› git log --show-signature                                                                   
commit cf00fde906628423c78340e1e26f105a4541a52f (HEAD -> dev/pierre.fayer/fix_ldp_archive_payload, origin/dev/pierre.fayer/fix_ldp_archive_payload)
gpg: Signature made Fri 01 Mar 2024 10:44:00 AM CET
gpg:                using EDDSA key E9C202EE8524306B1859990FCF3873C85DD3C6E7
gpg: Good signature from "Pierre Frayer <[email protected]>" [ultimate]
Author: Pierre Frayer <[email protected]>
Date:   Wed Feb 28 15:18:27 2024 +0100

    fix: logs data platform archive url payload

Nevertheless I added it

pfrayer avatar Mar 01 '24 10:03 pfrayer

This Pull Request is stale due to inactivity since 30 days. If no activity happens for 15 more days from now, it will be closed.

github-actions[bot] avatar Apr 12 '24 00:04 github-actions[bot]