OWLib icon indicating copy to clipboard operation
OWLib copied to clipboard

GitHub actions

Open evie404 opened this issue 3 years ago • 4 comments

example run: https://github.com/evie404/OWLib/actions/runs/2537687792

artifacts at the very bottom

evie404 avatar Jun 21 '22 19:06 evie404

we very well could use actions but switching away from appveyor breaks our automatic versioning. we would need to find a way to have something similar

ZingBallyhoo avatar Jun 21 '22 19:06 ZingBallyhoo

versioning like https://github.com/overtools/OWLib/blob/76cfdec98f9b8c884fa5a3439cda9af45978fd20/appveyor.yml#L1? where does the variable come from? i can try to replicate it in github actions

evie404 avatar Jun 21 '22 19:06 evie404

its intrinsic to appveyor https://www.appveyor.com/docs/build-configuration/#build-versioning

they also patch our csprojs to have the version https://www.appveyor.com/docs/build-configuration/#net-core-csproj-files-patching

ZingBallyhoo avatar Jun 21 '22 19:06 ZingBallyhoo

Yea i'm not an expert at Github Actions but I looked into this and I had some issues trying to replicate this behaviour. There are some Github Action plugins that try to replicate it but one of the main ones I tried only works in individual projects and not whole solutions like App Veyor does (which we need for DataTool and TankView).

I guess the only way to really do it easily would be to just manually regex the version in the .csproj for DataTool and TankView with some unique Github Actions build number.

Though i think it also appends the git commit as well. DataTool v1.72.0.993-git-76cfdec98f9b8c884fa5a3439cda9af45978fd20

Js41637 avatar Jun 21 '22 22:06 Js41637

closing as we now have gh actions.

neptuwunium avatar Oct 12 '22 03:10 neptuwunium