toolkit icon indicating copy to clipboard operation
toolkit copied to clipboard

remove version in the docker compose file

Open Milokita opened this issue 1 year ago • 2 comments

Description

remove version in the docker compose file

Related issues / Pull Requests

latest docker would report, this PR address this warning

"WARN[0000] overleaf-toolkit/lib/docker-compose.base.yml: `version` is obsolete"

Contributor Agreement

Milokita avatar Mar 30 '24 08:03 Milokita

This fix would still be much appreciated, I think. Is anyone able to approve and merge this? This will also simplify the creation of a docker compose override slightly.

ThexXTURBOXx avatar May 23 '24 07:05 ThexXTURBOXx

Thanks for the suggestion @Milokita!

This is currently blocked as we still need to support docker-compose v1 in the Toolkit and removing the version field changes the behavior of docker-compose v1/breaks setups.

As noted in the release notes for Server Pro 5.1, we are planning to drop support for docker-compose v1 with the next release. At this point we can adopt this PR.

das7pad avatar Jul 17 '24 09:07 das7pad