OpenDocumenter icon indicating copy to clipboard operation
OpenDocumenter copied to clipboard

Fix bin entrypoint

Open youaresofunny opened this issue 5 years ago • 6 comments

Description

Fixes wrong bin path in package.json

Type of change

Please delete options that are not relevant.

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] Any dependent changes have been merged and published in downstream modules

youaresofunny avatar Aug 17 '20 12:08 youaresofunny

Commit that broke it: https://github.com/ouropencode/OpenDocumenter/commit/9e82cb814ff99bb70389b5cbaf2dbf5d3e7da8d2

youaresofunny avatar Aug 17 '20 12:08 youaresofunny

Is there anything else we need to do for this to be merged and released?

cspotcode avatar Oct 26 '20 16:10 cspotcode

For reference: fixes #19 and probably #18

cspotcode avatar Oct 26 '20 16:10 cspotcode

I have made this fix and published a forked version to @cspotcode/opendocumenter: https://www.npmjs.com/package/@cspotcode/opendocumenter

cspotcode avatar Oct 26 '20 17:10 cspotcode

Should we leave this open since the issue is still not fixed?

cspotcode avatar Nov 19 '20 17:11 cspotcode

Should we leave this open since the issue is still not fixed?

Yup, this should've been left open. I mostly glance over the dependabot MRs as I'm quite busy right now. I'm going to reopen this and work on the project. a little over the next couple of weeks

R4wizard avatar Jan 27 '21 07:01 R4wizard