Sam Ottenhoff

Results 67 comments of Sam Ottenhoff

Thanks Julian! How about posting a pull request instead of a JIRA comment?

@ern how do you want to delete things like Assignments All Purpose Items? Do you want to do it via Hibernate cascading or do you want it implemented in deleteAssignmentAndAllReferences...

This would be a very good thing to get into trunk ;)

I left a comment in Jira, but I don't think this fixes issue

This seems to consistently break Cypress tests. I saw lots of errors in my console around theme switching. Maybe theme switcher was depending on something that got moved?

Bootstrap Icons are SVG which looks like a huge change. I would stick with FA

FA4 used web fonts thus you could do this: ``` a::before { content: "\f0da"; // fa-caret-right display: inline-block; width: 0.75em; // fixed width for both icons, similar to .fa-fw font-family:...

So if we keep FA4, I think we should import all of it into Sakai and then fix the math() so that we can upgrade to Dart Sass 2.0 .......