package-analysis icon indicating copy to clipboard operation
package-analysis copied to clipboard

Add function to parse analysis complete notification JSON

Open adaluong opened this issue 3 years ago • 3 comments

This function makes it easier for downstream consumers (like package analysis) to parse the package analysis complete notification and identify the package being analysed.

Signed-off-by: Ada Luong [email protected]

adaluong avatar Feb 10 '23 01:02 adaluong

Is this still required?

oliverchang avatar Feb 15 '23 05:02 oliverchang

@calebbrown do we need this code?

maxfisher-g avatar Feb 20 '23 02:02 maxfisher-g

Long term - yes, I think this is the right place for this. Marshal/Unmarshal logic best exists next to the struct itself (e.g. url.Parse).

In this particularly case I am planning a small refactor in https://github.com/ossf/package-analysis/issues/651. So it's not critical to have this merged. Given the lack of unit tests we probably want to wait.

calebbrown avatar Feb 20 '23 03:02 calebbrown