PostgreSQL 16 support

[devrimgunduz]

Hi,

Latest release fails to build (see below) against PostgreSQL 16, and v16 is due next week. Can you please fix and push a new release? Thanks!

-- Devrim

/usr/lib64/ccache/clang -Wno-ignored-attributes -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Xclang -no-opaque-pointers -Wno-unused-command-line-argument -Wno-compound-token-split-by-macro -O2 -I../include -I/usr/pgsql-16/include -I. -I./ -I/usr/pgsql-16/include/server -I/usr/pgsql-16/include/internal -D_GNU_SOURCE -I/usr/include/libxml2 -I/usr/include -flto=thin -emit-llvm -c -o pgut/pgut.bc pgut/pgut.c In file included from recovery.c:22: ../include/pg_loadstatus.h:16:10: fatal error: storage/relfilenode.h: No such file or directory 16 | #include "storage/relfilenode.h" | ^~~~~~~~~~~~~~~~~~~~~~~ compilation terminated. make[2]: *** [: recovery.o] Error 1 make[2]: *** Waiting for unfinished jobs.... In file included from recovery.c:22: ../include/pg_loadstatus.h:16:10: fatal error: 'storage/relfilenode.h' file not found #include "storage/relfilenode.h" ^~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. make[2]: *** [/usr/pgsql-16/lib/pgxs/src/makefiles/../../src/Makefile.global:1080: recovery.bc] Error 1 make[2]: Leaving directory '/home/devrim/Documents/Devrim/Projects/repo/pgrpms/rpm/redhat/main/non-common/pg_bulkload/main/pg_bulkload-VERSION3_1_20/bin' make[1]: *** [Makefile:27: all] Error 2 make[1]: Leaving directory '/home/devrim/Documents/Devrim/Projects/repo/pgrpms/rpm/redhat/main/non-common/pg_bulkload/main/pg_bulkload-VERSION3_1_20' error: Bad exit status from /var/tmp/rpm-tmp.0FS5eT (%build)

[devrimgunduz]

ping

[devrimgunduz]

ping?

[devrimgunduz]

ping

[ali-ramadhan]

I'm also unable to compile pg_bulkload against PostgreSQL v16.

root@1041a7e5d15b:/home/postgres/pg_bulkload-3.1.20# make
Makefile:33: warning: overriding recipe for target 'check'
/usr/lib/postgresql/16/lib/pgxs/src/makefiles/pgxs.mk:449: warning: ignoring old recipe for target 'check'
make[1]: Entering directory '/home/postgres/pg_bulkload-3.1.20/bin'
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wimplicit-fallthrough=3 -Wcast-function-type -Wshadow=compatible-local -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -g -g -O2 -flto=auto -ffat-lto-objects -flto=auto -ffat-lto-objects -fstack-protector-strong -Wformat -Werror=format-security -fno-omit-frame-pointer -I../include -I/usr/include/postgresql -I. -I./ -I/usr/include/postgresql/16/server -I/usr/include/postgresql/internal  -Wdate-time -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -I/usr/include/libxml2   -c -o recovery.o recovery.c
In file included from recovery.c:22:
../include/pg_loadstatus.h:16:10: fatal error: storage/relfilenode.h: No such file or directory
   16 | #include "storage/relfilenode.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[1]: *** [<builtin>: recovery.o] Error 1
make[1]: Leaving directory '/home/postgres/pg_bulkload-3.1.20/bin'
make: *** [Makefile:27: all] Error 2

[zwyan0]

Hi, @devrimgunduz , @ali-ramadhan

We just released pg_bulkload with postgresql 16 support. Please check it. 3.1.21

[ali-ramadhan]

Thank you @zwyan0 and @shinyaaa!