split-pro icon indicating copy to clipboard operation
split-pro copied to clipboard
verified publisher icon oss-apps

Feature Request: Translations

Open kruemelro opened this issue 1 year ago • 8 comments

It would be great to have the app in the user prefered language

kruemelro avatar Aug 26 '24 04:08 kruemelro

i've never done this before so might need some help.

KMKoushik avatar Aug 26 '24 04:08 KMKoushik

many other projects uses i18n for this. Sadly i'm not a developer who could help on implement this, but i can provide the full german translation as soon as a solution is in place.

kruemelro avatar Aug 26 '24 06:08 kruemelro

I can help your team in this process. Would you like to cooperate?

seyed-sabbagh avatar Aug 26 '24 06:08 seyed-sabbagh

@seyed-sabbagh that will awesome actually. lemme know if you need any help. we can discuss here

KMKoushik avatar Aug 26 '24 07:08 KMKoushik

  1. Is there a specific format I should use for the translations?
  2. Are there any particular issues I should focus on or specific guidelines I need to follow before I start?
  3. Should the translations I complete be submitted directly to the main repository, or should they first be submitted as a Pull Request? Additionally, could you please advise on which language I should start with?

seyed-sabbagh avatar Aug 26 '24 08:08 seyed-sabbagh

@seyed-sabbagh

  1. i don't have any particular format in mind, may be use the one what i18next is suggesting
  2. no guidelines for this, may be the best practices of i18next can help
  3. can make a PR

think you should just start with english, once modified we can add languages one by one

KMKoushik avatar Aug 26 '24 20:08 KMKoushik

I've got some free time and want to learn something new, so i had a look on my own. I implemented it and in my docker build all looks fine. @KMKoushik Please have a look over the code of the PR #89.

kruemelro avatar Aug 30 '24 12:08 kruemelro

I see PRs #89 and #208 but none of them got merged yet. Is there any requirement not met for this?

rodrigost23 avatar May 19 '25 17:05 rodrigost23

The #208 PR is newer and based on the previous one, it is under review now.

krokosik avatar May 22 '25 09:05 krokosik

@rodrigost23 @kruemelro the i18n feature has been merged to main in #259. Huge, huge thanks to @marcosinigaglia for delivering it and adding Italian 🥳 🙏

Also feel free to submit new translations :)

krokosik avatar Jul 30 '25 08:07 krokosik

Also feel free to submit new translations :)

This is great news, and I'm tempted to offer german translation. I'm not a decent developer, though, and unsure whether I'll be capable to set up the dev environment correctly. Do you have a hint how to start this? Does i18next provide a web tool of some sorts, or do I need to manually rewrite the JSON language files?

soeffi avatar Aug 04 '25 20:08 soeffi

@soeffi that would be great!

Setting up the environment is fairly simple, just make sure you have NodeJS v22 and Docker on your machine. Then you can follow the instructions in the README. Feel free to ask for advice in case of any issues.

As for editing the files themselves, I'm not aware of a visual editor, so copy pasting the json files and replacing their content is the way to go.

krokosik avatar Aug 05 '25 10:08 krokosik

Ok, I did a bit of searching. Will try the i18n-ally extension for vscode...

soeffi avatar Aug 05 '25 11:08 soeffi

@soeffi that would be great!

Done, see PR #295.

Hope I did everything right, I'm pretty new to this... Let me know, if I missed something

soeffi avatar Aug 09 '25 21:08 soeffi