gobgp icon indicating copy to clipboard operation
gobgp copied to clipboard

SetLargeCommunityMethod does not have 'large-community-set-ref'

Open emil-palm opened this issue 6 years ago • 1 comments

I think this might be a just a oversight but SetLargeCommunityMethod struct does not have a 'large-community-set-ref' as the other version has: https://github.com/osrg/gobgp/blob/master/internal/pkg/config/bgp_configs.go#L5039

vs

https://github.com/osrg/gobgp/blob/master/internal/pkg/config/bgp_configs.go#L5148 and https://github.com/osrg/gobgp/blob/master/internal/pkg/config/bgp_configs.go#L5084

Should be a simple fix

emil-palm avatar Feb 20 '19 10:02 emil-palm

Looks like an oversight. Updating gobgp.yang and adding such is fine by me but *community-set-ref isn't used by any code.

fujita avatar Feb 20 '19 11:02 fujita