hcpy icon indicating copy to clipboard operation
hcpy copied to clipboard

Handle 307 redirects in hc-login (#35)

Open jorritolthuis opened this issue 2 years ago • 2 comments

Properly handle 307 redirects, in the same way 302 redirects are already handled. See issue #35 and https://en.wikipedia.org/wiki/List_of_HTTP_status_codes#3xx_redirection.

jorritolthuis avatar Dec 10 '23 13:12 jorritolthuis

Had the same issue too. Testing is tricky but the code looks fine and does not break something else.

pmagyar avatar Dec 10 '23 17:12 pmagyar

I agree that testing is a problem. I was not able to find any documentation for singlekey-id.com, so best I can do is assume they strictly follow Oauth. But Oauth should never return a 307, so I'm slightly confused there.

In either case the hc-login script doesn't finish successfully for me. So I can't guarantee that 307 forward does/doesn't get me closer to a working setup.

jorritolthuis avatar Dec 10 '23 19:12 jorritolthuis