osquery-go issues

Add mutexes to osquery-go

1

As discussed in #98, osquery's communication is single threaded. This PR adds several mechanisms to help manage that. 1. Most critically, it adds mutexes to the underlying client calls to...

directionless

Should we add mutexs to osquery-go?

3

As I understand it, osquery's thrift interface is single threaded. But, this isn't mirrored in this SDK. We leave it to the caller to insure that `Query` is not called...

directionless

Extension cannot connect on first try when loaded automatically

3

#### Context osquery 4.2 Windows 10 Pro 64bit #### Test extension package main import ( "context" "flag" "log" "github.com/kolide/osquery-go" "github.com/kolide/osquery-go/plugin/table" ) func main() { flSocket := flag.String("socket", "", "") flag.Int("timeout",...

0xpaulbenoit

question

Constraints that are not `==` don't appear to be passed along

1

As pointed out on slack, it's not clear how to get a constraint that isn't `==` I added a spew to [`table.Call`](https://github.com/kolide/osquery-go/blob/5aaecb264273aeafc8b120728006204ee9ee2552/plugin/table/table.go#L54) and I don't see the constraints coming in....

directionless

Can't create socket file correctly, If defined an socket, but connect refused

- create an new socket, the result is context deadline exceeded err info: Error creating Thrift client: waiting for unix socket to be available: goosquery.em: context deadline exceeded exit status...

JosingCai

Is it possible to create event tables using osquery-go?

I'm hoping to create a custom "event" table (i.e. using https://osquery.readthedocs.io/en/stable/development/pubsub-framework rather than a traditional, on-demand generated table). It seems like `osquery-go` might only support the on-demand generate table style...

bradleyjkemp

Close the client pipe on shutdown

4

When shutting down the extension the named pipe that is created by the extension is closed however the "client" (the handle to the pipe created by osquery - used for...

sroache

Race condition when running example

6

While trying to track down a memory leak with my extension, I found there is a race condition. When running the example and using the -race flag with go run,...

avcarrillo