Oliver Smith-Denny

> A few remaining items that need to be address for this PR to be merged: > > 1. The goto label `Error_DeleteSNP` does not follow naming conventions. Recommend `ErrorDeleteSnp'...

@jyao1 @rahul1-kumar it is the hard freeze now and this is not targeted for that, but can you still review so I can make any requested changes for when the...

@jyao1 I think there may be some confusion with the name (which I can change if desired). This is not an implementation of the DebugLib library class, but rather a...

@jyao1 @rahul1-kumar can you please review now that the stable tag has been released?

> If the concern is size, we should have better way to handle that. > > Can you try to put the debug code to **DEBUG_CODE**() macro. (See https://github.com/tianocore/edk2/blob/master/MdePkg/Include/Library/DebugLib.h#L590C9-L590C19) ?...

@jyao1 the problem statement is that Tcg2Dxe (and related libs) is the noisiest driver in the tree by orders of magnitude. There are thousands of lines of code supporting this...

@jyao1 I think there is still a confusion based on the name (which can be changed). Instead of calling this Tpm2DebugLib, think of this as Tpm2ExtraInformationLib. It is _not_ an...

@jyao1 I clearly have not convinced you :) I don't want to spend more cycles here, so I will: - Drop the library and add a DEBUG_TPM bit in PcdDebugErrorLevel...

@jyao1 @rahul1-kumar I have updated this PR to move to DEBUG_TPM as discussed (and updated title/description), please re-review. @mdkinney @lgao4 I have updated this PR to make changes to MdePkg...

@mdkinney @jyao1 @rahul1-kumar @lgao4 please review