hydra icon indicating copy to clipboard operation
hydra copied to clipboard
verified publisher icon ory

fix: use up-to-date `kid` in JWT header when refreshing

Open tilgovi opened this issue 10 months ago • 7 comments

This PR is a variation on #3942 that attempts to solve the problem by letting fosite set the kid header of tokens and removing all of the code to explicitly set this header in JWTs.

tilgovi avatar Apr 05 '25 19:04 tilgovi

Not sure if there's anything I should do about the CodeQL scanning results task failing. It seems spurious.

tilgovi avatar Apr 07 '25 17:04 tilgovi

I pushed up three commits to restore the extra key, validate the UUID format, and remove some of the extraneous diff.

tilgovi avatar Apr 17 '25 20:04 tilgovi

Also, please let me know how you'd like me to resolve conflicts, if at all. I can merge or rebase or squash at your preference.

tilgovi avatar Apr 17 '25 21:04 tilgovi

I realized the checks wouldn't even run due to the conflict, so I rebased and squashed.

tilgovi avatar Apr 17 '25 21:04 tilgovi

And, I think the CI jobs flaked, but I can't re-run them. 😞

tilgovi avatar Apr 18 '25 16:04 tilgovi

@aeneasr anything more I can do here?

tilgovi avatar May 01 '25 17:05 tilgovi

@aeneasr is it possible to get this change merged?

permfl avatar Sep 22 '25 19:09 permfl