fosite icon indicating copy to clipboard operation
fosite copied to clipboard

refresh flow: prevent accidentially returned token

Open sja opened this issue 3 years ago • 1 comments

In case the transaction commit fails, the responder reference was already modified which could result in a token returned which was not persisted.

Related Issue or Design Document

Checklist

  • [x] I have read the contributing guidelines and signed the CLA.
  • [ ] I have referenced an issue containing the design document if my change introduces a new feature.
  • [x] I have read the security policy.
  • [x] I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security vulnerability, I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • [ ] I have added tests that prove my fix is effective or that my feature works.
  • [ ] I have added the necessary documentation within the code base (if appropriate).

Further comments

sja avatar Oct 05 '22 19:10 sja

Can you add tests for this?

mitar avatar Feb 15 '24 07:02 mitar