docs icon indicating copy to clipboard operation
docs copied to clipboard

Recovery documentation page broken?

Open aeneasr opened this issue 3 years ago • 3 comments

Discussed in https://github.com/ory/kratos/discussions/2566

Originally posted by jonnyijapan July 4, 2022 If I open this link: https://www.ory.sh/docs/kratos/self-service/flows/account-recovery#recovery-for-server-side-browser-clients

It shows a page that looks like this. It looks like it might be broken, or some design isn't working. It looks like a dark blue background, with text that is dark brown/grey. The text is almost invisible, it's not easy to even spot the text. image

If I do a cmd-a to select all text, the text becomes easier to see... image

aeneasr avatar Jul 05 '22 13:07 aeneasr

I also have a similar issue with darkmode enabled on the recovery documentation [1]. Without darkmode it looks good again.

[1]

Screenshot 2022-08-05 at 11 08 31

jonas-jonas avatar Aug 05 '22 09:08 jonas-jonas

We probably just have to tweak the mermaid template a bit https://github.com/sjwall/mdx-mermaid/pull/21

This PR will (hopefully?) fix it: https://github.com/facebook/docusaurus/pull/7490 So the question is if we wait for this or make a custom mermaid style for darkmode before.

vinckr avatar Aug 09 '22 17:08 vinckr

Hm it seems the mermaid blocks have the same styling as "info" admonissions. if we can override --ifm-color-info-contrast-background just for the mermaid graphs that would fix it.

vinckr avatar Aug 09 '22 17:08 vinckr

Not valid anymore after merging https://github.com/ory/docs/pull/995

tomekpapiernik avatar Nov 04 '22 13:11 tomekpapiernik