docs icon indicating copy to clipboard operation
docs copied to clipboard

docs: update deploy-hydra-example.mdx

Open andreadistefano opened this issue 1 year ago • 1 comments

Add server_name directive also in the listen 443 server block to deal with multiple virtual hosts.

I followed the guide on a local server I had lying around which already had nginx installed with some virtual hosts. (I know I should run it on a dedicated server but this is just a test environment).

I couldn't figure out why the provided nginx configuration was not working, until I realized that I needed to add the server_name directive also in the listen 443 server block, or nginx would serve content from a different virtual host.

I think the directive doesn't have any impact if the virtual host for Ory Hydra is the only one on the machine, but it's necessary if someone has other virtual hosts already configured.

Checklist

  • [x] I have read the contributing guidelines and signed the CLA.
  • [ ] I have referenced an issue containing the design document if my change introduces a new feature.
  • [x] I have read the security policy.
  • [x] I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security vulnerability, I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • [ ] I have added tests that prove my fix is effective or that my feature works.
  • [ ] I have added the necessary documentation within the code base (if appropriate).

andreadistefano avatar Mar 20 '24 11:03 andreadistefano

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Mar 20 '24 11:03 CLAassistant