closed-reference-notifier icon indicating copy to clipboard operation
closed-reference-notifier copied to clipboard

Move ignore marker at the beginning of the url

Open jooola opened this issue 3 years ago • 0 comments

Preflight checklist

Describe the bug

Related to 5d419e0124280696469e6e862a4ab1cfb39f9d84

[Code] editors usually make link clickable for developers convenience. The ignore marker at the end of the URL might get consider as part of the URL and clicking on them will open a HTTP 404 in our browsers.

Some link checkers might also get confused by this, and report false positives.

Moving the ignore marker a the beginning of the URL should prevent mixing them together as we often have the scheme that delimits the beginning of the URL.

I see that the regex rule to extract the links does not contain any scheme, but maybe we could use https://regex101.com/r/K8XC3H/1 ?

(!!)?((https?:)?\/\/)?github\.com\/([a-zA-Z\d-]+)\/([a-zA-Z\d._-]+)\/(pull|issues)\/(\d+)(!!)?

Reproducing the bug

  • Open your IDE and click on a link with the ignore markers.
  • Should open a 404 in your browser

Relevant log output

No response

Relevant configuration

No response

Version

v1

On which operating system are you observing this issue?

No response

In which environment are you deploying?

No response

Additional Context

No response

jooola avatar Sep 10 '22 08:09 jooola