orels-Unity-Shaders icon indicating copy to clipboard operation
orels-Unity-Shaders copied to clipboard

[ORL-67] Albedo channel select is selecting the wrong channel

Open JotaPe opened this issue 2 years ago • 3 comments

Describe the bug Because of indexing being wrong, the albedo channel dropdown is selecting the wrong channel

To Reproduce 1 - Use the Standard Orels Shader 2 - Put a texture on the Albedo 3 - Select a channel

Expected behavior Select the correct channel for albedo colors

Screenshots

image

Texture with this blue channel

image

Blue Channel selected on material, but instead is selecting the alpha channel

Environment:

  • OS: Windows 10
  • Unity Version: 2022.3.6f1
  • Shaders Version: 6.3.0
  • Rendering Pipeline: Built-in

Additional context Would be a easy fix, just minus 1 on the _AlbedoChannel in the shader source code, already did that on my version.

From SyncLinear.com | ORL-67

JotaPe avatar Jan 12 '24 10:01 JotaPe

ORL Standard.orlshader Line 118 From: albedo.rgb = albedo[_AlbedoChannel].xxx; to: albedo.rgb = albedo[_AlbedoChannel - 1].xxx;

JotaPe avatar Jan 12 '24 10:01 JotaPe

Figured it out when using your shader to make materials with "advanced channel packing" where the blue channel is the albedo.

JotaPe avatar Jan 12 '24 10:01 JotaPe

Oh right, because default is RGB, so i need to offset it by 1! Good catch, and thank you for the report, I'll throw this into the next release

orels1 avatar Jan 12 '24 10:01 orels1