oci-cloud-controller-manager
oci-cloud-controller-manager copied to clipboard
oracle
Match nodes by complete hostame rather than prefix to avoid false +
Greetings!
This pull-request resolves #388 by matching the complete hostname when looking for a node.
Note that this is not a theoretical issue, we have a customer who's (instance pool backed) nodes are causing this to happen:
ERROR cloud/node_controller.go:140 GetInstanceByNodeName: too many instances returned for node name "ashburn-ops-node-ad1-vnic-850450": 2
the above fix resolve the issue for them.
Pull Request Test Coverage Report for Build 2399192961
- 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage remained the same at 29.32%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
|---|---|---|---|
| pkg/oci/client/compute.go | 0 | 1 | 0.0% |
| <!-- | Total: | 0 | 1 |
| Totals | |
|---|---|
| Change from base Build 2369846621: | 0.0% |
| Covered Lines: | 2581 |
| Relevant Lines: | 8803 |
