oci-cloud-controller-manager icon indicating copy to clipboard operation
oci-cloud-controller-manager copied to clipboard

Increase default timeout of Context when making OCI calls.

Open jlamillan opened this issue 3 years ago • 1 comments

Greetings!

This pull-request resolves #387 by increasing the default timeout of HTTP requests to OCI from 10 seconds to 5 minutes.

5 minutes may seem excessive, but (1) the compute.GetInstanceByNodeName() function needs time to iterate through potentially all the VNICs in a compartment and (2) we have a customer running a cluster of hundreds of nodes (and several hundred VNIC attachments) and we have confirmed that it requires several minutes to complete.

jlamillan avatar May 27 '22 23:05 jlamillan

Pull Request Test Coverage Report for Build 2399182508

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 29.32%

Totals Coverage Status
Change from base Build 2369846621: 0.0%
Covered Lines: 2581
Relevant Lines: 8803

💛 - Coveralls

coveralls avatar May 27 '22 23:05 coveralls