oracle
Reflect the errors of report generating
Description At the moment, all of our Reporter here does not return anything even when errors happen while generating the reports. Therefore, it's better for us to return the error accordingly so that the Analyzer could decide on the exit status code (https://github.com/oracle-samples/macaron/issues/175).
Description At the moment, all of our Reporter here does not return anything even when errors happen while generating the reports. Therefore, it's better for us to return the error accordingly so that the Analyzer could decide on the exit status code (#175).
Do you have any specific scenario in mind? In most cases the report generator should not make the process exit.
In most cases the report generator should not make the process exit.
Yes that is true. I was thinking about whether we should explicitly show the user that the reports could not be generated (of an expected internal error - so I don't have a concrete scenario yet). For example, at the moment, if Macaron cannot generate the report, the return status code would still be 0 (no error) if the analysis succeed. I am thinking that the user might not aware of it and look into the old version of the reports or could not find the report anywhere.
I am thinking that the user might not aware of it and look into the old version of the reports or could not find the report anywhere.
We should remove old results before producing new results to avoid this. I'm not sure if we should return an error code, which would be considered as Macaron's analysis failure.