dtrace-utils icon indicating copy to clipboard operation
dtrace-utils copied to clipboard

configure's `mandir` has unusual behaviour

Open thesamesam opened this issue 1 year ago • 3 comments

Nick and I already discussed this a bit but filing a bug so I don't have to juggle so much in my head.

With the usual mandir (the base of the man directory, not a specific category), we end up with dtrace.8 being installed into mandir, not the correct category subdir.

I had to adjust the ebuild like:

-               --mandir="${EPREFIX}"/usr/share/man
+               --mandir="${EPREFIX}"/usr/share/man/man8

See https://bugs.gentoo.org/938209 and 850a084b7f9ba426afb1febec97c613c90498484 in gentoo.git.

thesamesam avatar Sep 12 '24 00:09 thesamesam

This is already fixed in the relocatable dtrace patch series

ezannoni avatar Oct 11 '24 16:10 ezannoni

Can someone add a ref to the commit that fixes it. As far as I know that should already be on devel.

kvanhees avatar Oct 11 '24 19:10 kvanhees

I must have hallucinated fixing it. Fix on the internal gentoo bugfixing branch now.

nickalcock avatar Oct 23 '24 11:10 nickalcock

Thanks!

thesamesam avatar Oct 30 '24 22:10 thesamesam

Unfortunately, the fix isn't quite right for DESTDIR:

	install -m 644 $(dtrace_DIR)/dtrace.8 $(INSTMANDIR)/man8

We end up with:

 * CMP: =dev-debug/dtrace-9999 with dev-debug/dtrace-9999/image
 *  FILES:-usr/share/man/man8/dtrace.8.xz
 *  FILES:+usr/share/man/man8.xz
 * ------> FILES(+1,-1)

thesamesam avatar Oct 30 '24 23:10 thesamesam

Ugh. I tested this, dammit. Fixing.

nickalcock avatar Oct 31 '24 17:10 nickalcock

(And yes, the lack of a mkdir is problematical!)

nickalcock avatar Oct 31 '24 17:10 nickalcock

Posted fix for review -- actually two bugs with the same effect, one mkdir of the wrong directory and one total failure to mkdir at all (in dtprobed/, unsurprisingly, since that didn't even have a manpage until recently).

nickalcock avatar Oct 31 '24 17:10 nickalcock

Ah, and that explains why I only saw the one file being added too (which I didn't clock until you said this...), as one clobbers the other with the bad name.

thesamesam avatar Oct 31 '24 17:10 thesamesam

Looking good now, thanks!

thesamesam avatar Nov 06 '24 07:11 thesamesam