php-sdk icon indicating copy to clipboard operation
php-sdk copied to clipboard

Explicitly define class properties

Open benschoch opened this issue 2 years ago • 5 comments

Summary

  • Explicitly define class properties to get rid of deprecation warnings

Issues

  • Fixes #283

Issues

FSSDK-10015

benschoch avatar Feb 13 '24 10:02 benschoch

Hiya @benschoch,

Thanks for the collaboration and the code update. I'm running this through our Product team for managing priority.

Are you blocked by this code change?

mikechu-optimizely avatar Feb 13 '24 18:02 mikechu-optimizely

Hey, thanks for the quick answer. It isn’t blocking, no. Even though it really spams our logs currently 😉

benschoch avatar Feb 14 '24 07:02 benschoch

I've created internal ticket FSSDK-10015.

Please review and sign the Contributor License Agreement from CONTRIBUTING.md.

Thanks for the collab.

mikechu-optimizely avatar Feb 14 '24 20:02 mikechu-optimizely

Please review and sign the Contributor License Agreement from CONTRIBUTING.md.

benschoch avatar Feb 15 '24 08:02 benschoch

Cool. Thanks. I'm holding for Product to prioritize...but honestly (and gratefully), you've done the work. It should be low-hanging completion.

mikechu-optimizely avatar Feb 15 '24 14:02 mikechu-optimizely

Hi @mikechu-optimizely, are there any plans to release this change sometime soon? I’d greatly appreciate any information you can share.

arouchdi avatar Feb 07 '25 18:02 arouchdi

Hi @mikechu-optimizely, are there any plans to release this change sometime soon? I’d greatly appreciate any information you can share.

Hey @arouchdi & @benschoch. I'm realizing this ticket slipped under our radar. Our engineering manager has allocated this into a future sprint and will update here. Thanks for hanging in there.

mikechu-optimizely avatar Feb 07 '25 19:02 mikechu-optimizely

Hey, @benschoch. Pulled your PR into internal PR for CI run. Closing this one in exchange for #288

FarhanAnjum-opti avatar Mar 11 '25 15:03 FarhanAnjum-opti