Jordan/fix group by getter

Open jordangarcia opened this issue 10 years ago • 4 comments

@lyonlai I checked out your branch and noticed a couple of test failures for some observer unwatch edge cases. I've added two new tests in master for these test cases and updated your branch to address these.

Mind giving this a PR before I merge? #183

Nov 03 '15 19:11 jordangarcia

@jordangarcia looks like you've missed the commit 77ced5e6358c2e515a29b2295bd73729834bd914 about the new test case in this PR.

Nov 03 '15 20:11 lyonlai

@lyonlai that commit is already in master and included in https://github.com/optimizely/nuclear-js/commit/f979b20235bdd51e37284671fcc0f91764fb2d5c

Nov 03 '15 20:11 jordangarcia

@jordangarcia I see. The code is good to go for me. :airplane:

Nov 03 '15 20:11 lyonlai

LGTM too. :+1:

Nov 04 '15 05:11 bhamodi