opsdroid icon indicating copy to clipboard operation
opsdroid copied to clipboard

Remove unused dependency: websockets

Open gdrosos opened this issue 2 years ago • 1 comments

Summary

Hello @jacobtomlinson @spinits4 ,

I hope you're all doing well! I've just opened this pull request that proposes the removal of the unused websockets dependency from the setup.cfg configuration file. It's part of an ongoing research endeavor focusing on the identification and elimination of code bloat within software projects. Your insights on this would be really valuable.

Rationale

The websockets library was integrated into the project via 5b4c5df, were it was utilised in slack connector. However, its usage was discontinued in a subsequent commit, d034972, where the slack connector was adapted to use the slackclient library . Despite this change in the codebase, websockets continued to be listed in the project's dependency files. Removing this unused dependency can reduce the overall footprint of the application, mitigate potential security risks, and simplify the dependency management process.

Changes

  • Removed the websockets dependency from the setup.cfg file.

Impact

  • Reduced package size: Eliminating this unused dependency will decrease the overall size of the installed packages.

  • Simplified dependency tree: A leaner list of dependencies aids in more straightforward project maintenance and faster installations.

Status

READY

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Ran tests through tox

Checklist:

  • [x] I have performed a self-review of my own code
  • [ ] I have made corresponding changes to the documentation (if applicable)
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes

gdrosos avatar Aug 27 '23 13:08 gdrosos

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.16%. Comparing base (ad52d90) to head (b239273). Report is 6 commits behind head on master.

:exclamation: Current head b239273 differs from pull request most recent head a949d2e. Consider uploading reports for the commit a949d2e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2007      +/-   ##
==========================================
+ Coverage   99.02%   99.16%   +0.14%     
==========================================
  Files          83       83              
  Lines        5414     5395      -19     
==========================================
- Hits         5361     5350      -11     
+ Misses         53       45       -8     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 27 '23 13:08 codecov[bot]