improve environment var testing
Description
- check vs const rather than (unknown) os.environ
- (TODO) adds a test that loads env var that was set using
.bashrc,source, or similar
Creates test for issue reported in matrix chat. Chat summary:
7yl4r: I need some clarification on how to use environment variables with connectors. I am trying to use them in the config. I am getting auth errors because the env vars are not being inserted into the config. I tried putting the environment vars into a
.envfile andsourceing it. I also tried adding them to my.bashrc. Neither seems to have worked.
Status
UNDER DEVELOPMENT
Type of change
- Added tests
- (TODO) Bug fix (non-breaking change which fixes an issue)
- (TODO) Documentation (fix or adds documentation)
How Has This Been Tested?
- I opened this PR so that I can test using GH-actions CI
Checklist:
- [ ] I have performed a self-review of my own code
- [ ] I have made corresponding changes to the documentation (if applicable)
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
Codecov Report
Base: 99.47% // Head: 99.47% // No change to project coverage :thumbsup:
Coverage data is based on head (
dda7ccf) compared to base (73da764). Patch has no changes to coverable lines.
Additional details and impacted files
@@ Coverage Diff @@
## master #1956 +/- ##
=======================================
Coverage 99.47% 99.47%
=======================================
Files 80 80
Lines 5129 5129
=======================================
Hits 5102 5102
Misses 27 27
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
I'm going through and closing out stale PRs here. Sorry we never got this over the line.