oppia
Admin Controls icon color incorrect in API 19 [Blocked on #3853]
In the screenshot we can notice that the icon color of Administrator Controls is orange even when its not selected. This needs to be fixed.
Expected behaviour: Icon + Text color when selected -> Orange Icon + Text color when not selected -> black
Take exact color code from colors.xml file and from other similar icons.
Hey, I think the expected API level is 21+ right?
@aadityaguptaa Actually for the minimum API version is 19.
Ohh okay, my bad. But the project uses OkHttp which works on API 21+. That's why my app keeps crashing.
Ohh okay, my bad. But the project uses OkHttp which works on API 21+. That's why my app keeps crashing.
@aadityaguptaa Yes that's correct. I think I will have to solve this as there is one branch of mine in which I am not facing these crashes so I can leverage that to showcase that my solution works. @aadityaguptaa Can you pick some other issue to work on ?
@Rishavgupta12345 this is something that you'll need to investigate. One thing that can be really helpful is to look at strings on the screen that you're trying to find the code for, then look up those strings in code (which will correspond to string IDs), and then find which layouts/Kotlin files those strings are referenced in (which will either provide the exact files responsible for that screen, or the files responsible for a constituent piece of the screen).
This issue is specific to API 19 only. So please create an emulator accordingly.
@Rishavgupta12345 I have unassigned this issue as per your request, do let me know in case you want to pick it up again
@bkaur-bkj Can you please assign me this issue?
as this issue is currently begin assigned to Shubhanshu you can try picking up other issues
can u pl guide me how to start , very eager to contribute. currently figuring out where the issue code .
can u pl guide me how to start , very eager to contribute. currently figuring out where the issue code .
@shubhanshu-coder Please checkout our wiki first. This will help you in setting up the project and once you sign the CLA and fill the survey form we can assign you issues to work on.
i have filled the CLA and the survey form . now i can start next ?
@shubhanshu-coder You can find CLA here: https://github.com/oppia/oppia-android/wiki/Contributing-to-Oppia-android#onboarding-instructions
@shubhanshu-coder Are you still working on this issue or Can I take it?
This issue seems to have been fixed, I checked the develop branch and its been fixed
Yes this issue is fixed. I would like someone from community to close this issue.
@YesShubham01 I did check this on latest develop code and it is still not fixed.
Device Config: API 19 Kitkat Pixel 2 Android 4.4 armeabi-v7a
@seanlip @rt4914 I think this is happening because the brown icon is selected for administrator controls. I am able to change it to grey icon. But I'm not able to change the color according to whether the button is selected or not.
I get the error "This feature requires ASM7" when I try to put conditionals -
Can you please help me, and if possible assign me the issue?
@nawaz-anwar Please provide an explanation of what your PR will do (with names of files you're changing, what you plan to change in each file, etc.). If it looks good, we can assign you to this issue.
@seanlip @rt4914 I think this is happening because the brown icon is selected for administrator controls. I am able to change it to grey icon. But I'm not able to change the color according to whether the button is selected or not.
I get the error "This feature requires ASM7" when I try to put conditionals -
Can you please help me, and if possible assign me the issue?
@seanlip @rt4914 Can you please comment on this?