core icon indicating copy to clipboard operation
core copied to clipboard

Incorrect loglevels for gateway log

Open dwkirw opened this issue 1 year ago • 4 comments

Important notices

Before you add a new report, we ask you kindly to acknowledge the following:

  • [X] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
  • [X] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Describe the bug

  • PPPoE / Gateway monitoring has had an overhaul in 24.7.2 and its fixed the issues I was having.
    I've noticed though that in the System-Gateways-Logfile that the dpinger settings and resets are being marked with a loglevel of Warning.
  • Warning dpinger exiting on signal 15
  • Warning dpinger send_interval 5000ms loss_interval 4000ms time_period 60000ms report_interval 0ms data_len 5 alert_interval 1000ms latency_alarm 0ms loss_alarm ....

To Reproduce

Steps to reproduce the behavior:

  1. System-Gateways-Logfile
  2. If gateway monitoring is turned on then the settings for dpinger will be shown with an error level of Warning

Expected behavior

I would have expected both to have a level of 'Informational'

Describe alternatives you considered N/A

Screenshots

Screenshot of both is attached.

Relevant log files

The last day or so of my log is attached.

Environment

Software version used and hardware type:

OPNsense 24.7.2 (amd64). Intel i3-10110U 2.1Ghz Dual Core Protectli Vault VP4630

Screenshot 2024-08-23 054032 GatewayLog.txt

dwkirw avatar Aug 22 '24 19:08 dwkirw

I‘m marking this upstream. A GitHub repository for dpinger exists where this could be discussed with the author.

fichtner avatar Aug 22 '24 20:08 fichtner

Thank you Fichtner - I should log this issue there as well?

dwkirw avatar Aug 22 '24 20:08 dwkirw

Appear to me that it's always warning whenever syslog (-S) is used. Apparently by design.

doktornotor avatar Aug 22 '24 20:08 doktornotor

Ok, I had some closer look at the code, it really has no concept of loglevels. There are 21 logger() calls. For some, the desired loglevel is obvious (and should be error, not warning), for some - not very much so. Regardless - this is nontrivial amount of code to be changed, noone wants to maintain such patchsets downstream.

image

You really should file an issue / feature request at the dpinger repo.

doktornotor avatar Aug 25 '24 10:08 doktornotor

This issue has been automatically timed-out (after 180 days of inactivity).

For more information about the policies for this repository, please read https://github.com/opnsense/core/blob/master/CONTRIBUTING.md for further details.

If someone wants to step up and work on this issue, just let us know, so we can reopen the issue and assign an owner to it.

OPNsense-bot avatar Feb 18 '25 19:02 OPNsense-bot