openproject icon indicating copy to clipboard operation
openproject copied to clipboard

[#70183] Fix Work Package Export dialog resizing on switching format

Open myabc opened this issue 1 month ago • 1 comments

Ticket

https://community.openproject.org/work_packages/70183

What are you trying to accomplish?

Fixes Work Package Export dialog resizing by changing size to medium_portrait.

Screenshots

BEFORE AFTER
CSV Screenshot 2026-01-05 at 13 36 53 Screenshot 2026-01-05 at 13 36 11
PDF Screenshot 2026-01-05 at 13 36 47 Screenshot 2026-01-05 at 13 36 18

What approach did you choose and why?

This PR makes the Export dialog portrait - which IMO looks better. An alternative strategy could be to add a minimum height, but I think that probably warrants discussion with UX/UI team first.

Merge checklist

  • [ ] Added/updated tests
  • [ ] Added/updated documentation in Lookbook (patterns, previews, etc)
  • [ ] Tested major browsers (Chrome, Firefox, Edge, ...)

myabc avatar Jan 05 '26 16:01 myabc

Hi @myabc With the new changes, the dialog height is not stable either.

https://github.com/user-attachments/assets/a7d2030c-e586-4267-baa7-068c9aaf02b9

But I think it should be discussed with designers. cc/ @psatyal , @marcalcobe Codewise, it looks good to me, but I'm not sure about how it looks now. It can be merged after designers approve it.

bsatarnejad avatar Jan 06 '26 10:01 bsatarnejad