openproject icon indicating copy to clipboard operation
openproject copied to clipboard

[57405] Use Primer's PageHeader component on the WorkPackage list view

Open HDinger opened this issue 1 year ago • 0 comments

Ticket

https://community.openproject.org/projects/design-system/work_packages/57405/activity

What are you trying to accomplish?

Use the Primer::OpenProject::PageHeader and Primer::OpenProject::SubHeader in the WorkPackage table view

What approach did you choose and why

We have to do the full removal of uiRouter in one go as we'd otherwise face a lot of issues with the isolatedQuerySpace which we'd costly have to fix temporarily.

Todo

PageHeader

  • [ ] Title

    • [ ] Show current query name
    • [ ] Is editable
    • [ ] When the query is changed, we follow the same pattern as on the project list: On the right, there is an indicator saying "List modified: {{save_icon}} Save". Clicking on "Save" will save the view
  • [x] Full screen button

  • [ ] More menu

    • [ ] Transformed into Primer menu
    • [ ] Those actions that trigger a dialog will trigger a Primer Dialog with the (unchanged) content inside

SubHeader

  • [ ] Filter button

    • [ ] Shows current acitve filter numbers
    • [ ] On click, the filter section is opened (the section itself is unchanged)
  • [x] Create button

    • [x] Transformed into Primer menu

Routing

  • [x] Remove routes from Angular and route from rails instead
    • [x] Show (Full and split)
    • [x] Create (Full and split)
    • [x] Copy (Full only)
  • [ ] Remove all references to the uiRouter params and stateTransitions

Other modules

  • [ ] Should be working globally and in a project scope
  • [ ] Ideally, the header of other modules is changed in the same run (as they share the same implementation)
    • [ ] BIM?
    • [ ] Gantt?
    • [ ] TeamPlanner?
    • [ ] Calendar?
    • [ ] Boards?

General requirements

  • [ ] Permission checks
  • [ ] Adapt tests
  • [ ] Remove obsolete angular code

Open questions

  • [ ] Baseline button

    • [ ] Part of the PageHeader (?)
    • [ ] Will open the previous (unchanged) content in a dialog instead of a dropmodal
  • [ ] Include projects button

    • [ ] Part of the PageHeader (?)
    • [ ] Will open the previous (unchanged) content in a dialog instead of a dropmodal
  • [ ] Split screen button

    • [ ] Open: Possibly removed?

Screenshots

Bildschirmfoto 2024-09-11 um 11 07 46

HDinger avatar Sep 11 '24 09:09 HDinger