openproject icon indicating copy to clipboard operation
openproject copied to clipboard

Feature/storybook

Open b12f opened this issue 3 years ago • 1 comments

This installs storybook and adds a docker container for it.

The deleted component file was apparently a leftover that should've been deleted earlier. It broke the storybook build because the template import was not available.

Still includes the default stories that storybook installs.

Relates to: https://community.openproject.org/work_packages/41847 Relates to: https://community.openproject.org/projects/openproject/work_packages/33242/

b12f avatar Jun 14 '22 14:06 b12f

Only had the time for a short glimpse yet, but a few things popped up:

  1. We don't want to commit the documentation.json, as it is being rebuild on every serve and will be impossible to merge automatically.
  2. I'd expect the first merged version to include a documentation of at least part of the spot components. This certainly doesn't have to be complete, but we shouldn't merge the default examples
  3. The past times I've tried storybook, using an angular component from within mdx would always fail for mysterious reasons. It's been a while since I tried, but I'd like to see that working before we continue

oliverguenther avatar Jun 15 '22 07:06 oliverguenther