operator-marketplace icon indicating copy to clipboard operation
operator-marketplace copied to clipboard

Updating marketplace-operator images to be consistent with ART [4.9]

Open openshift-bot opened this issue 2 years ago • 7 comments

Updating marketplace-operator-container image to be consistent with ART for 4.9 TLDR: Product builds replace base and builder images as configured. This PR is to ensure that CI builds use the same base images as the product builds.

Component owners, please ensure that this PR merges as it impacts the fidelity of your CI signal. Patch-manager / leads, this PR is a no-op from a product perspective -- feel free to manually apply any labels (e.g. jira/valid-bug) to help the PR merge as long as tests are passing. If the PR is labeled "needs-ok-to-test", this is to limit costs for re-testing these PRs while they wait for review. Issue /ok-to-test to remove this tag and help the PR to merge.

Detail: This repository is out of sync with the downstream product builds for this component. One or more images differ from those being used by ART to create product builds. This should be addressed to ensure that the component's CI testing is accurately reflecting what customers will experience.

The information within the following ART component metadata is driving this alignment request: marketplace-operator.yml.

The vast majority of these PRs are opened because a different Golang version is being used to build the downstream component. ART compiles most components with the version of Golang being used by the control plane for a given OpenShift release. Exceptions to this convention (i.e. you believe your component must be compiled with a Golang version independent from the control plane) must be granted by the OpenShift architecture team and communicated to the ART team.

Roles & Responsibilities:

  • Component owners are responsible for ensuring these alignment PRs merge with passing tests OR that necessary metadata changes are reported to the ART team: @release-artists in #forum-ocp-art on Slack. If necessary, the changes required by this pull request can be introduced with a separate PR opened by the component team. Once the repository is aligned, this PR will be closed automatically.
  • Patch-manager or those with sufficient privileges within this repository may add any required labels to ensure the PR merges once tests are passing. Downstream builds are already being built with these changes. Merging this PR only improves the fidelity of our CI.

Change behavior of future PRs:

  • In case you just want to follow the base images that ART suggests, you can configure additional labels to be set up automatically. This means that such a PR would merge without human intervention (and awareness!) in the future. To do so, open a PR to set the auto_label attribute in the image configuration. Example
  • You can set a commit prefix, like UPSTREAM: <carry>: . An example.

If you have any questions about this pull request, please reach out to @release-artists in the #forum-ocp-art coreos slack channel.

openshift-bot avatar Sep 29 '23 17:09 openshift-bot

/retest

perdasilva avatar Oct 09 '23 09:10 perdasilva

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: anik120, openshift-bot Once this PR has been reviewed and has the lgtm label, please assign kevinrizza for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Oct 13 '23 13:10 openshift-ci[bot]

/label backport-risk-assessed

oceanc80 avatar Oct 13 '23 13:10 oceanc80

/retest-required

KeenonLee avatar Oct 17 '23 03:10 KeenonLee

/retest-required

KeenonLee avatar Nov 08 '23 05:11 KeenonLee

/retest

grokspawn avatar Feb 13 '24 14:02 grokspawn

/retest

perdasilva avatar Jun 27 '24 06:06 perdasilva

@openshift-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-aws 75087f04fd8b2e2df8f4002e663e58e0c354fa10 link false /test okd-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Jun 27 '24 07:06 openshift-ci[bot]

OCP version no longer supported. Please re-open if required.

perdasilva avatar Jun 27 '24 12:06 perdasilva