operator-lifecycle-manager icon indicating copy to clipboard operation
operator-lifecycle-manager copied to clipboard

Fix example string for svg icon types

Open ivandov opened this issue 3 years ago • 3 comments

Valid values are listed in the OpenAPISchema specification of the ClusterServiceVersion CRD

https://github.com/operator-framework/operator-lifecycle-manager/blob/master/deploy/upstream/manifests/0.7.0/03-clusterserviceversion.crd.yaml#L124-L128

Description of the change: Fix documentation example for SVG icon types

Motivation for the change: Using the example image/svg without the +xml suffix will cause rendering errors in OCP.

Architectural changes: None

Testing remarks:

Reviewer Checklist

  • [ ] Implementation matches the proposed design, or proposal is updated to match implementation
  • [ ] Sufficient unit test coverage
  • [ ] Sufficient end-to-end test coverage
  • [ ] Bug fixes are accompanied by regression test(s)
  • [ ] e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • [ ] tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • [ ] Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • [ ] Docs updated or added to /doc
  • [ ] Commit messages sensible and descriptive
  • [ ] Tests marked as [FLAKE] are truly flaky and have an issue
  • [ ] Code is properly formatted

ivandov avatar Aug 03 '22 18:08 ivandov

Hi @ivandov. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Aug 03 '22 18:08 openshift-ci[bot]

New changes are detected. LGTM label has been removed.

openshift-ci[bot] avatar Aug 09 '22 23:08 openshift-ci[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: exdx, ivandov, timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Aug 09 '22 23:08 openshift-ci[bot]

@ivandov could you please fix the DCO action? NOTE I've rebased the PR from this side. So, you should do a git pull --rebase && git commit --sign --amend && git push

DCO

There is one commit incorrectly signed off. This means that the author of this commit failed to include a Signed-off-by line in the commit message.

To avoid having PRs blocked in the future, always include Signed-off-by: Author Name [email protected] in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).

Here is how to fix the problem so that this code can be merged.

Rebase the branch

If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").

You should only do this if:

You are the only author of the commits in this branch You are absolutely certain nobody else is doing any work based upon this branch There are no empty commits in the branch (for example, a DCO Remediation Commit which was added using --allow-empty) To add your Signed-off-by line to every commit in this branch:

Ensure you have a local copy of your branch by checking out the pull request locally via command line. In your local branch, run: git rebase HEAD~1 --signoff Force push your changes to overwrite the branch: git push --force-with-lease origin patch-1

perdasilva avatar Feb 28 '23 09:02 perdasilva

New changes are detected. LGTM label has been removed.

openshift-ci[bot] avatar Mar 03 '23 09:03 openshift-ci[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: exdx, ivandov, perdasilva, timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Apr 11 '23 12:04 openshift-ci[bot]

closing in favor of #2953 - due to DCO blocking the merge. @ivandov I hope it's ok with you that I've taken the liberty of cloning your PR.

perdasilva avatar Apr 13 '23 12:04 perdasilva