operator-lifecycle-manager icon indicating copy to clipboard operation
operator-lifecycle-manager copied to clipboard

Update for new grpc library

Open perdasilva opened this issue 3 years ago • 5 comments

Description of the change: Updates olm to use the lates operator-registry release

Motivation for the change: It's a been a while, and the latest version contains the latest version of the grpc library with security fixes needed by the downstream. See https://github.com/operator-framework/operator-registry/issues/959

Reviewer Checklist

  • [ ] Implementation matches the proposed design, or proposal is updated to match implementation
  • [ ] Sufficient unit test coverage
  • [ ] Sufficient end-to-end test coverage
  • [ ] Docs updated or added to /doc
  • [ ] Commit messages sensible and descriptive
  • [ ] Tests marked as [FLAKE] are truly flaky
  • [ ] Tests that remove the [FLAKE] tag are no longer flaky

perdasilva avatar Jun 01 '22 12:06 perdasilva

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Jun 01 '22 12:06 openshift-ci[bot]

@anik120 could you please review this? I'm a bit worried about the metrics. This update changes the way grpc connection states change. Basically they remain on idle until there's an rpc call before they transition to ready. Any idea how this could affect SRE?

perdasilva avatar Jun 09 '22 09:06 perdasilva

Also, we probably want to set catalogSourceReady to 1 in both the Idle and Ready state here too.

anik120 avatar Jun 09 '22 15:06 anik120

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot avatar Jun 20 '22 16:06 openshift-bot

/hold

perdasilva avatar Jun 20 '22 16:06 perdasilva

closing this as it's stale

perdasilva avatar Feb 28 '23 09:02 perdasilva