operator-framework
[WIP] Remove grace period from csv deletions
Signed-off-by: perdasilva [email protected]
Description of the change: This PR removes the 0 grace period from the CSV deletion calls
Motivation for the change: This causes all csv owned objects to also be deleted with a 0 grace period. This is impacting a customer that relies on grace period to clean up their pods.
Seems like there are other good reasons as well:
Force deleting a pod is not allowed for automated processes within Kube or OpenShift unless done so by a human. That action is reserved because it is effectively bypassing the safety mechanisms of a cluster which ensure that only one pod is on any one node at a time, and leaves the state of the system inconsistency between apiserver and node (the node may still run that old process indefinitely).
Reviewer Checklist
- [ ] Implementation matches the proposed design, or proposal is updated to match implementation
- [ ] Sufficient unit test coverage
- [ ] Sufficient end-to-end test coverage
- [ ] Docs updated or added to
/doc - [ ] Commit messages sensible and descriptive
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: perdasilva
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [perdasilva]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@perdasilva: This pull request references Bugzilla bug 2039950, which is invalid:
- expected the bug to target the "4.10.0" release, but it targets "---" instead
Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.
In response to this:
Bug 2039950: Remove grace period from csv deletions
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@perdasilva: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.
In response to this:
[WIP] Remove grace period from csv deletions
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@perdasilva I removed the BZ reference on the title. You only include the BZ info on downstream PR.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: perdasilva, tmshort
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [perdasilva]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment