operator-controller icon indicating copy to clipboard operation
operator-controller copied to clipboard

Review Reason and Type strings in ClusterExtension API.

Open tmshort opened this issue 1 year ago • 3 comments

We discussed a similar topic here: do we really need these reasons? I don't think we have a use case for this just yet.

ReasonErrorGettingClient can be replaced with a more generic ReasonInstallationFailed. Same, probably, goes for ReasonBundleLoadFailed too, but there is another question about related condition type TypeHasValidBundle above.

See also #842

Originally posted by @m1kola in https://github.com/operator-framework/operator-controller/pull/846#discussion_r1604761276

tmshort avatar May 21 '24 19:05 tmshort

Looks as though #842 changed title, so it's not just making conditions consistent any more. This should probably be part of the effort of this issue.

tmshort avatar Jun 03 '24 14:06 tmshort

@bentito are you basically working on this?

tmshort avatar Jun 06 '24 19:06 tmshort

yes

bentito avatar Jun 06 '24 20:06 bentito

We did a whole API review. So closing this old issue.

tmshort avatar Nov 19 '24 14:11 tmshort