operator-controller icon indicating copy to clipboard operation
operator-controller copied to clipboard

🌱 Internal Rukpak Package Tests

Open dtfranz opened this issue 1 year ago β€’ 2 comments

Adds more tests to the packages migrated from rukpak.

Closes #1037

Reviewer Checklist

  • [ ] API Go Documentation
  • [ ] Tests: Unit Tests (and E2E Tests, if appropriate)
  • [ ] Comprehensive Commit Messages
  • [ ] Links to related GitHub Issue(s)

dtfranz avatar Aug 07 '24 16:08 dtfranz

Deploy Preview for olmv1 ready!

Name Link
Latest commit 916f9e487393e41122177411e51a98a3059c0381
Latest deploy log https://app.netlify.com/sites/olmv1/deploys/66c36ba86567ba000839a751
Deploy Preview https://deploy-preview-1100--olmv1.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Aug 07 '24 16:08 netlify[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 76.85%. Comparing base (74959d0) to head (916f9e4). Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1100      +/-   ##
==========================================
+ Coverage   75.44%   76.85%   +1.40%     
==========================================
  Files          35       35              
  Lines        1918     1918              
==========================================
+ Hits         1447     1474      +27     
+ Misses        329      310      -19     
+ Partials      142      134       -8     
Flag Coverage Ξ”
e2e 58.08% <ΓΈ> (-0.11%) :arrow_down:
unit 54.58% <ΓΈ> (+3.70%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 07 '24 16:08 codecov[bot]

Overall looks good to me. Left a general comment for comparison of the image registry tests implemented here and in catalogd, but it doesn't need to be addressed for this PR to merge IMO.

It currently looks to me like I'll need to keep the low-level http response stuff in there for some of the error returns; I'll revisit this at another time and merge for now. Thank you!

dtfranz avatar Aug 26 '24 16:08 dtfranz