zipkin-ruby icon indicating copy to clipboard operation
zipkin-ruby copied to clipboard

protect against double inserting middlewares

Open jcarres-mdsol opened this issue 6 years ago • 3 comments

It seems that mistake do happen and does not look nice. Thoughts on the approach? I could not find a way to find out at initialization time.

@ykitamura-mdsol @jfeltesse-mdsol

jcarres-mdsol avatar Sep 07 '19 02:09 jcarres-mdsol

Why not just fix the mistake?

ykitamura-mdsol avatar Sep 09 '19 17:09 ykitamura-mdsol

is this to prevent end users from shooting themselves in the foot by adding the middleware twice in their chain?

jfeltesse-mdsol avatar Sep 10 '19 06:09 jfeltesse-mdsol

Right, is to prevent users from adding it twice. I've seen this happen in one instance, could fix it in the project which did it instead and there is an argument for doing that instead. But on the other hand do not want to play a whac-a-mole game. What do you think?

jcarres-mdsol avatar Sep 10 '19 16:09 jcarres-mdsol