usteer
usteer copied to clipboard
Channel load steering never triggered
It seems that the is_better_candidate function never returns UEV_SELECT_REASON_LOAD, because the condition is unsatisfiable. It is essentially p ∧ ¬p, unless some pointer aliasing happens in-between.
Probably the parameters were supposed to be flipped in the second call.
https://github.com/openwrt/usteer/blob/e218150979b40a1b3c59ad0aaa3bbb943814db1e/policy.c#L110-L112
Just came across the same thing. Another issue seems to be that below_load_threshold actually implements above_load_threshold.