packages icon indicating copy to clipboard operation
packages copied to clipboard

watchcat: error if only one address is specified in pinghosts

Open st7105 opened this issue 1 month ago • 0 comments

Package Name

watchcat

Maintainer

Roger D [email protected]

OpenWrt Version

SNAPSHOT

OpenWrt Target/Subtarget

mediatek/filogic

Steps to Reproduce

  1. Add configuration in /etc/config/watchcat:

config watchcat option period '60s' option mode 'run_script' option script '/etc/custom_user_script.sh' option addressfamily 'ipv4' option pingperiod '10s' option pingcount '3' option pingsize 'standard' option interface 'wg0' list pinghosts '10.11.1.1'

  1. /etc/init.d/watchcat start

Actual Behaviour

In the error logs:

Wed Dec 17 08:18:01 2025 daemon.info watchcat[20977]: Could not reach "10.11.1.1" via "wg0" for "20" seconds. Running script after reaching "60" seconds

I checked the result of executing the ping command inside the script and saw an error: ping: bad address '"10.11.1.1"'

I believe the ping team does not appreciate unnecessary double quotes. Most likely, this commit broke: https://github.com/openwrt/packages/commit/5dc13908b48c48ba995ec23ddf983268ec3426b7

Confirmation Checklist

  • [x] The package is maintained in this repository.
  • [x] I understand that issues related to the base OpenWrt repository or LuCI repository will be closed.
  • [x] I am reporting an issue for OpenWrt, not an unsupported fork.

st7105 avatar Dec 17 '25 05:12 st7105