packages icon indicating copy to clipboard operation
packages copied to clipboard

kmsbd-tools: fix version after apk changes

Open pesa1234 opened this issue 1 year ago • 5 comments

Solved strange package version 0~ to match apk format.

Maintainer: nobody Compile tested: mediatek/filogic GL.iNet GL-MT6000 OpenWRT snapshot r25663-ce0cf80dac

Run tested: mediatek/filogic GL.iNet GL-MT6000 OpenWRT snapshot r25663-ce0cf80dac Tested -add new user -mod existing user

Description: Previous version ksmbd-avahi-service 0~3.5.1-r1 ksmbd-hotplug 0~3.5.1-r1 ksmbd-server 0~3.5.1-r1

Actual: ksmbd-avahi-service 3.5.1-r2 ksmbd-hotplug 3.5.1-r2 ksmbd-server 3.5.1-r2

pesa1234 avatar Mar 30 '24 08:03 pesa1234

  1. Commit message should be like this:

    • kmsbd-tools: use tagged release

    • kmsbd-tools: switch to use tagged release

    1. In the commit description: Instead of checking Git sources, we will use now tagged releases, because of smth...

Thanks, I'll fix it

pesa1234 avatar Mar 30 '24 13:03 pesa1234

https://github.com/openwrt/packages/commit/de64b43e3cf7a3cb3501dfde3d8b1fbfe7478c76 It was changed to use git sources by purpose, not sure if it works properly nowadays.

1715173329 avatar Mar 30 '24 14:03 1715173329

de64b43 It was changed to use git sources by purpose, not sure if it works properly nowadays.

I didn't see any strange things right now

pesa1234 avatar Mar 30 '24 17:03 pesa1234

I think, I will leave here this discussion: https://lists.openwrt.org/pipermail/openwrt-devel/2024-March/042499.html

BKPepe avatar Mar 30 '24 17:03 BKPepe

I think, I will leave here this discussion:

If I understand good, it isn't great things what I've done... I don't know to solve the strange version to make it compatible with apk without this swap. So, if it isn't good the swap feel free to close.

Thanks!

Andrea

pesa1234 avatar Mar 30 '24 18:03 pesa1234

Nono, Andrea you did not do anything wrong. You did yours best here, nothing to worry about. The timing was not perfect, but it happens. Many packages are downloading tarball or checking out Git sources, so we should not block this PR as there is no conclusion what is better/preferable.

Hopefully, the issue which was pointed out by @1715173329 is narrowed down. Lets see it by merging this.

BKPepe avatar Mar 31 '24 07:03 BKPepe

yeah

1715173329 avatar Mar 31 '24 09:03 1715173329