OpenWPM icon indicating copy to clipboard operation
OpenWPM copied to clipboard

Refactor/extension unification

Open vringar opened this issue 3 years ago • 3 comments

vringar avatar Mar 25 '22 11:03 vringar

I did a quick review and this LGTM. Do we know why the tests aren't running?

englehardt avatar Mar 25 '22 13:03 englehardt

GitHub actions are currently under maintenance. See https://www.githubstatus.com/

vringar avatar Mar 25 '22 13:03 vringar

Codecov Report

Merging #983 (6664d73) into master (65c284b) will decrease coverage by 2.94%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #983      +/-   ##
==========================================
- Coverage   52.53%   49.58%   -2.95%     
==========================================
  Files          34       34              
  Lines        3392     3392              
==========================================
- Hits         1782     1682     -100     
- Misses       1610     1710     +100     
Impacted Files Coverage Δ
openwpm/deploy_browsers/deploy_firefox.py 24.39% <0.00%> (ø)
openwpm/utilities/db_utils.py 66.66% <0.00%> (-30.00%) :arrow_down:
openwpm/utilities/multiprocess_utils.py 28.57% <0.00%> (-26.20%) :arrow_down:
openwpm/js_instrumentation.py 73.11% <0.00%> (-22.59%) :arrow_down:
openwpm/errors.py 80.95% <0.00%> (-19.05%) :arrow_down:
openwpm/config.py 84.92% <0.00%> (-11.12%) :arrow_down:
openwpm/browser_manager.py 68.34% <0.00%> (-6.54%) :arrow_down:
openwpm/task_manager.py 76.44% <0.00%> (-3.12%) :arrow_down:
openwpm/command_sequence.py 90.76% <0.00%> (-3.08%) :arrow_down:
openwpm/commands/utils/webdriver_utils.py 19.31% <0.00%> (-2.28%) :arrow_down:
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 65c284b...6664d73. Read the comment docs.

codecov-commenter avatar Apr 13 '22 10:04 codecov-commenter