OpenWPM icon indicating copy to clipboard operation
OpenWPM copied to clipboard

Clarify wording in docs/Configuration.md wrt collection_fingerprinting

Open tim-stephenson opened this issue 3 years ago • 2 comments

https://github.com/openwpm/OpenWPM/blob/abf10d745a42f6781a1b6116976a613900f73977/docs/Configuration.md?plain=1#L162-L174 The statement:

 - `collection_fingerprinting` is the default if `js_instrument` is `True`. 

Is false, as it is no longer the default. I found this a bit confusing while reading over the docs.

tim-stephenson avatar Oct 14 '22 18:10 tim-stephenson

I can confirm that collection_fingerprinting is still the default. https://github.com/openwpm/OpenWPM/blob/abf10d745a42f6781a1b6116976a613900f73977/openwpm/config.py#L83-L85 But I get how the docs are confusing in this aspect.

vringar avatar Oct 16 '22 12:10 vringar

The docs should be updated to state, that the js_instrument_settings, that were the default prior to v0.11.0 have been grouped into a collection called collection_fingerprinting and that this collection is the default configuration, when enabling the js_instrument.

vringar avatar Oct 16 '22 12:10 vringar