openwisp-radius icon indicating copy to clipboard operation
openwisp-radius copied to clipboard

[bug] FreeRADIUS PostAuthView returns 500 error

Open pandafy opened this issue 3 years ago • 8 comments

The FreeRADIUS PostAuthView (/api/v1/freeradius/postauth/) returns HTTP 500 error if the length of called_station_id field exceeds 50 characters.

A possible fix could be to update the PostAuthSerializer and set max_length attribute on the called_station_id field. This way, the view would return HTTP 400 with the error reason.

pandafy avatar Jan 11 '23 12:01 pandafy

@pandafy I want to work on this issue, can you assign this issue to me?

ujjwalkirti avatar Aug 16 '23 07:08 ujjwalkirti

@ujjwalkirti you can start working on this issue. You don't need to wait for someone to assign this issue to you, just an intent message is enough. 😄

I would recommend you to start by writing a failing test case before updating the serializer.

I would also recommend you to join the OpenWISP development chat.

pandafy avatar Aug 16 '23 10:08 pandafy

can i start working on this?

nick2432 avatar Dec 20 '23 12:12 nick2432

Yes @nick2432, go ahead! Don't forget to read my previous comments.

pandafy avatar Dec 20 '23 12:12 pandafy

#509

samirgorai avatar Jan 28 '24 16:01 samirgorai

I want to work on this issue , can you pls assign me this ?

sumiran18 avatar Aug 11 '24 06:08 sumiran18

Welcome @sumiran18! Create a PR first, then I'll assign it to you.

nemesifier avatar Aug 12 '24 14:08 nemesifier